Skip to content

[8.1] PilotAgentsDB: move DN in favor of username#7157

Merged
fstagni merged 5 commits into
DIRACGrid:integrationfrom
fstagni:81_pilotDNUserName
Aug 24, 2023
Merged

[8.1] PilotAgentsDB: move DN in favor of username#7157
fstagni merged 5 commits into
DIRACGrid:integrationfrom
fstagni:81_pilotDNUserName

Conversation

@fstagni

@fstagni fstagni commented Aug 3, 2023

Copy link
Copy Markdown
Contributor
  • update wiki

This PR simplifies the PilotsAgentsDB content, eliminating information that is most probably not useful.

BEGINRELEASENOTES

*WMS
CHANGE: PilotAgentsDB: move DN in favor of username

ENDRELEASENOTES

@fstagni fstagni requested a review from atsareg as a code owner August 3, 2023 13:18
@fstagni fstagni force-pushed the 81_pilotDNUserName branch 8 times, most recently from ceacd26 to c6ba208 Compare August 7, 2023 12:18
@martynia

Copy link
Copy Markdown
Contributor

I'm wondering if OwnerGroup is really obsolete. I'm using it to get a VO of a pilot (this is basically an extension to export_getPilotOutput():

       # get pilot stamp by pilot reference:
        result = self.pilotAgentsDB.getPilotInfo(pilotReference)
        if not result["OK"]:
            self.log.error("Failed to get info for pilot", result["Message"])
            return S_ERROR("Failed to get info for pilot")
        if not result["Value"]:
            self.log.warn("The pilot info is empty", pilotReference)
            return S_ERROR("Pilot info is empty")

        pilotDict = result["Value"][pilotReference]
        pilotStamp = pilotDict["PilotStamp"]
        owner = pilotDict["OwnerDN"]
        group = pilotDict["OwnerGroup"]
        vo = getVOForGroup(group)

I need the VO to get to the correct storage area, when retrieving the logs (#7105)

@fstagni

fstagni commented Aug 15, 2023

Copy link
Copy Markdown
Contributor Author

Well, indeed we need a way to recognize for which VO pilots have been sent. OwnerGroup can be an option. I will restore it.

@fstagni fstagni force-pushed the 81_pilotDNUserName branch 2 times, most recently from defef17 to c8082fa Compare August 15, 2023 15:51
@fstagni

fstagni commented Aug 23, 2023

Copy link
Copy Markdown
Contributor Author

(final) review of this one before tomorrow's hacakathon?

Comment thread release.notes Outdated
Comment thread src/DIRAC/Interfaces/scripts/dirac_admin_get_job_pilots.py Outdated
Comment thread src/DIRAC/Interfaces/scripts/dirac_admin_get_job_pilots.py Outdated
Comment thread src/DIRAC/Interfaces/scripts/dirac_admin_get_pilot_info.py Outdated
@fstagni fstagni force-pushed the 81_pilotDNUserName branch from c8082fa to 8c13c25 Compare August 23, 2023 09:08

@aldbr aldbr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fstagni fstagni merged commit a90acce into DIRACGrid:integration Aug 24, 2023
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sweep:ignore Prevent sweeping from being ran for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants